JCollection Homepage

  • Increase font size
  • Default font size
  • Decrease font size
Home Forum
Welcome, Guest
Please Login or Register.    Lost Password?

Things Show When They Shouldn't: logo / 0 reviews
(1 viewing) (1) Guest
Go to bottomPage: 1
TOPIC: Things Show When They Shouldn't: logo / 0 reviews
#187
Things Show When They Shouldn't: logo / 0 reviews 10 Months ago  
Hi,

In version 0.4.3 I've noticed a couple of things showing up even though a setting says they shouldn't

1. I had a problem (0 reviews) showing near the title. In collection.default.php around line 520 I needed to put quotation marks around a php If statement:
if("$params->get('reviews')">0) {
This ensures that "reviews" only appears if reviews really are above 0.

2. Even though in the Menu config no image is selected, the Collection image shows up. This wasn't compatible with my theme:
I had to add $img = ' ' around line 281 and get rid of alt a couple of lines down.

Cheers
stephen
Posts: 6
graphgraph
User Offline Click here to see the profile of this user
The administrator has disabled public write access.
 
#188
Re:Things Show When They Shouldn't: logo / 0 reviews 10 Months ago  
Hi,
thanks for the report, your comments may help other users.
stephen wrote:
Hi,

In version 0.4.3 I've noticed a couple of things showing up even though a setting says they shouldn't

1. I had a problem (0 reviews) showing near the title. In collection.default.php around line 520 I needed to put quotation marks around a php If statement:
if("$params->get('reviews')">0) {
This ensures that "reviews" only appears if reviews really are above 0.


No, it doesn't. Correct would be a check if $row->numreviews > 0.

Regards,
Thorsten.
tcriess
Posts: 224
graph
User Offline Click here to see the profile of this user
The administrator has disabled public write access.
 
#190
Re:Things Show When They Shouldn't: logo / 0 reviews 10 Months ago  
I see. Well, the main thing for me was to stop (0 reviews) from showing right next to book titles and adding quotation marks did it. I guess there are many options one could try. Perhaps there could be a config option for it?

Thanks for the great component.
stephen
Posts: 6
graphgraph
User Offline Click here to see the profile of this user
The administrator has disabled public write access.
 
Go to topPage: 1

Donations

If you like JCollection, please consider a small donation to help developing the component. If you don't have a PayPal account and still wish to donate, feel free to send an Amazon.de gift certificate (to thorsten.riess@sh-riess.de). Thank you very much!

Amount: 

Flattr

Advertisement